Suboptimal workaround for forking when applying updates.#1785
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for #1759. Ideally, this issue will be fixed with the approach taken in #1767. However, that exposed a bug in webgme-engine and is currently blocked. As #1759 is blocking #1747 (which in turn is blocking #1694), I am opening this temporary workaround so we don't have 3 different PRs blocked by the webgme-engine issue (webgme/webgme-engine#222).
This PR changes the application of updates to be applied serially. Once the library updates have been applied, it waits a short amount of time to (hopefully) allow the changes to take effect. Then it runs the migrations using the ApplyUpdates plugin.